Conversation
|
Thanks. I'm really busy this weekend, but I'll try to review this within the next week. If I haven't given another update toward of the end of next week, feel free to ping me. |
|
No problem, take your time. |
|
I never got back to this because I removed it from my todo list when you said you were going to write docs. Let me know if you've got time to do that. If not, I can write them up. |
There was a problem hiding this comment.
Missing space before the closing paren.
|
Overall this looks pretty good. I'll do some actual testing soon. |
|
Sorry to say I currently don't have any time to edit the README. |
|
Is the only thing preventing this from being merged the README? I'm happy write up the docs. If something else needs to be done, I'm happy to take on those edits on as well. Thanks for your work on this guys! |
|
@NathanKleekamp That would be great. There are also some outstanding comments from my earlier review that need to be addressed. Thanks! |
|
OK, I've brought down @MichielDeMey 's changes into my local repo. Once I'm finished, I'm going to submit this as a separate pull request, since I don't have write access to his fork. Otherwise, I think I'd have to submit my changes as a pull request to his pull request. This way he doesn't need to take any further action. Sound OK? |
|
A PR to my PR sounds like a possible solution. |
|
A PR to @MichielDeMey's branch is certainly possible, but will put the discussion into his fork rather than here. Starting a new PR sounds good. I'll wait until you submit the new PR before closing this one. |
|
OK, one thing I've come across is that Are you all OK with me dropping |
|
Sure. When I get some time I can look into how to make that call. |
Implemented user functions according to http://codex.wordpress.org/XML-RPC_WordPress_API/Users
TODO: