Skip to content

Conversation

@schaefert1
Copy link
Owner

What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)

What did you learn from the changes you have made?

Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?

Were there any challenges? If so, what issue(s) did you face? How did you overcome it?

How were these changes tested?

A reference to a related issue in your repository (if applicable)

Checklist

  • I can confirm that my changes are working as intended

Copy link

@juliagallucci juliagallucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're on the right track. For part B, your current code always makes both words lowercase (word_a.lower() / word_b.lower()), even if is_case_sensitive=True! Then, if they are anagrams, you return True only when case-insensitive, otherwise False. Please revise.

Copy link

@juliagallucci juliagallucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're almost there! For part B, when is_case_sensitive=True, you’re not sorting the words. Right now, sorting only happens if case sensitivity is False. Please revise

@schaefert1
Copy link
Owner Author

You're almost there! For part B, when is_case_sensitive=True, you’re not sorting the words. Right now, sorting only happens if case sensitivity is False. Please revise

Updated

Copy link

@juliagallucci juliagallucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants