use IndexOutOfBoundsException constructor with Int
#24764
Draft
+26
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The exact format is not part of the specification of the constructors (see https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/lang/IndexOutOfBoundsException.html#%3Cinit%3E(int))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea of using
scala.runtime.Statics.ioobewas to reduce the size of the generated bytecode.In this PR, we instead use the JDK9+ constructor of
IndexOutOfBoundsException.In the generated code,
checkcastmentioned in scala/scala#7086 (comment) is also not present making the generated code more efficient than what it looked like in Scala 2.One question remains, should we deprecate
scala.runtime.Statics.ioobe?I believe we shouldI did deprecate it.scala3/library/src/scala/runtime/Statics.java
Line 151 in 7eba9a7
Closes #23971