packaging fixes #16
Open
packaging fixes #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 11, 2014
|
+1 from a non-developer trying to package Motion for NixOS :-) PS: I think a variant of that last commit ("fix build for non-x86 platforms [...]") has been merged to master. |
Added 3.4 to CHANGELOG
Release 3.4.0
The proper idiom is: memset(ptr, val, sizeof(*ptr)); These files were using: memset(ptr, val, sizeof(ptr));
The proper idiom for calculating the size for memory allocation is: ptr = malloc(sizeof(*ptr)); The sizeof() dereferences the pointer's type, and allocates enough memory to store an instance of that type. motion.c was using this idiom: ptr = malloc(sizeof(ptr)); This is incorrect, but thankfully fairly harmless in practice since the pointer type is usually quite large. Change this to the proper idiom.
Fix incorrect sizeof() calculations in malloc and memset
This function always returned `ret`, so might as well take a shortcut and return the pointer directly.
Calling free() on a NULL pointer is a completely harmless. Reduce code complexity by removing the unnecessary checks.
support -b to force running in background
Tweaks to uses of 'mymalloc'
Patch proposed by Github user aklomp Link: Motion-Project/motion#49
… header line, when the Hostname header was empty or malformed.
As documented in issue 169, the recentlay added MMAL camera support for the Raspberry Pi does not build on the Wheezy version of Raspbian. This option disables the autoconf generation of MMAL dependencies.
Revise the log level to warning when the user has specified a pgm mask file that is different than the size of the image from the camera. Free the memory associated with mask image to close memory leak.
Change --without-sdl to --with-sdl=[DIR]
Updated extpipe examples with ultrafast H264 (ffmpeg, mencoder and x264)
Fix hostname determination for IPv6 addresses in web server.
Adds --without-mmal option to configure.
Cleanup HTML.
Remove Fedora initscript (use the systemd service file instead)
Camera configuration directory
Add systemd service file
ffmpeg seems to put a \n on the end of messages, and MOTION_LOG also adds one, so remove the ffmpeg one.
Small fixes for recent changes
Remove old files
man pages are typically for UNIX systems where the line endings are LF not CRLF. The file currently uses a mix of both, urgh.
Motion already installs motion-dist.conf to @sysconfdir@/motion/, but some documentation was not updated to reflect this yet.
Certain symbols like - and \ need to be escaped in the man format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
18 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am updating this package in Debian and along the way have made some vendor-agnostic fixes. Please review and merge.