Homework 2 #775
Open
Homework 2 #775
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
new homework 1 corrected homework 1 corrected-new homework 1 corrected-new1 homework 1 corrected-new2 homework 1 corrected-new3 homework 1 corrected-new4 homework 1 corrected-new5 homework 1 corrected-new6 homework 1 corrected-new7 homework 1 right i homework 1 right i homework 1 right i homework 1 corrected commit1 commit2 corrected corrected1 corrected corrected
houndci-bot
reviewed
Apr 6, 2018
houndci-bot
left a comment
houndci-bot
left a comment
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
.rubocop.yml: Lint/BlockAlignment has the wrong namespace - should be Layout
.rubocop.yml: Lint/BlockAlignment has the wrong namespace - should be Layout .rubocop.yml: Lint/DefEndAlignment has the wrong namespace - should be Layout .rubocop.yml: Lint/EndAlignment has the wrong namespace - should be Layout Error: The `Style/TrailingCommaInLiteral` cop no longer exists. Please use `Style/TrailingCommaInArrayLiteral` and/or `Style/TrailingCommaInHashLiteral` instead. (obsolete configuration found in .rubocop.yml, please update it) obsolete parameter MaxLineLength (for Style/IfUnlessModifier) found in .rubocop.yml `Style/IfUnlessModifier: MaxLineLength` has been removed. Use `Metrics/LineLength: Max` instead obsolete parameter MaxLineLength (for Style/WhileUntilModifier) found in .rubocop.yml `Style/WhileUntilModifier: MaxLineLength` has been removed. Use `Metrics/LineLength: Max` instead
Xanderwot
suggested changes
Apr 10, 2018
| @@ -0,0 +1,44 @@ | |||
| require 'terminfo' | |||
Contributor
There was a problem hiding this comment.
Прям вот лишнее что-то затесалось.
| @@ -0,0 +1,2 @@ | |||
| --- | |||
| BUNDLE_NO_PRUNE: "true" | |||
| @@ -0,0 +1,3 @@ | |||
| add | |||
Contributor
There was a problem hiding this comment.
лучше всю историю кинуть в игнор.
2018/YuliyaBondareva/2/lib/help.rb
Outdated
| class Help < Base | ||
|
|
||
| def send_messages | ||
| telegram_send_message('Hello. See what I\'m doing |
Contributor
There was a problem hiding this comment.
что-то с отступами прям плохое
2018/YuliyaBondareva/2/lib/search.rb
Outdated
| end | ||
|
|
||
| def commits(query) | ||
| client = Octokit::Client.new(:login => 'YuliyaBond', :password => 'Sharik1109') |
Contributor
There was a problem hiding this comment.
Очень плохо хранить пароли в открытом доступе. Кидай такие вещи в yml файл какой и считывай его, а сам файл должен быть в игноре и не лететь в гит.
2018/YuliyaBondareva/2/lib/search.rb
Outdated
| end | ||
|
|
||
| def add_history(query) | ||
| File.open("./chat_ids/#{@user_id}_history", 'a') { |f| |
Contributor
There was a problem hiding this comment.
многострочные блоки оборачиваются в do end
| require_relative 'lib/search' | ||
| require_relative 'lib/history' | ||
|
|
||
| token = '581093532:AAFnA2apTDoU2WwtL9feOskYXIqA1UCOClk' |
Contributor
There was a problem hiding this comment.
тоже прям секретная информация
|
|
||
| end | ||
| end | ||
| end No newline at end of file |
Contributor
There was a problem hiding this comment.
добавь в конфигурацию своего редактора new line after save - что-то тип такого. Гугл должен знать.
|
|
||
| class History < Base | ||
| def send_messages | ||
| lines = IO.readlines("./chat_ids/#{@user_id}_history") |
houndci-bot
reviewed
Apr 12, 2018
houndci-bot
left a comment
houndci-bot
left a comment
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
.rubocop.yml: Lint/BlockAlignment has the wrong namespace - should be Layout
.rubocop.yml: Lint/BlockAlignment has the wrong namespace - should be Layout .rubocop.yml: Lint/DefEndAlignment has the wrong namespace - should be Layout .rubocop.yml: Lint/EndAlignment has the wrong namespace - should be Layout Error: The `Style/TrailingCommaInLiteral` cop no longer exists. Please use `Style/TrailingCommaInArrayLiteral` and/or `Style/TrailingCommaInHashLiteral` instead. (obsolete configuration found in .rubocop.yml, please update it) obsolete parameter MaxLineLength (for Style/IfUnlessModifier) found in .rubocop.yml `Style/IfUnlessModifier: MaxLineLength` has been removed. Use `Metrics/LineLength: Max` instead obsolete parameter MaxLineLength (for Style/WhileUntilModifier) found in .rubocop.yml `Style/WhileUntilModifier: MaxLineLength` has been removed. Use `Metrics/LineLength: Max` instead
houndci-bot
reviewed
Apr 12, 2018
houndci-bot
left a comment
houndci-bot
left a comment
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
.rubocop.yml: Lint/BlockAlignment has the wrong namespace - should be Layout
.rubocop.yml: Lint/BlockAlignment has the wrong namespace - should be Layout .rubocop.yml: Lint/DefEndAlignment has the wrong namespace - should be Layout .rubocop.yml: Lint/EndAlignment has the wrong namespace - should be Layout Error: The `Style/TrailingCommaInLiteral` cop no longer exists. Please use `Style/TrailingCommaInArrayLiteral` and/or `Style/TrailingCommaInHashLiteral` instead. (obsolete configuration found in .rubocop.yml, please update it) obsolete parameter MaxLineLength (for Style/IfUnlessModifier) found in .rubocop.yml `Style/IfUnlessModifier: MaxLineLength` has been removed. Use `Metrics/LineLength: Max` instead obsolete parameter MaxLineLength (for Style/WhileUntilModifier) found in .rubocop.yml `Style/WhileUntilModifier: MaxLineLength` has been removed. Use `Metrics/LineLength: Max` instead
houndci-bot
reviewed
Apr 12, 2018
houndci-bot
left a comment
houndci-bot
left a comment
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
.rubocop.yml: Lint/BlockAlignment has the wrong namespace - should be Layout
.rubocop.yml: Lint/BlockAlignment has the wrong namespace - should be Layout .rubocop.yml: Lint/DefEndAlignment has the wrong namespace - should be Layout .rubocop.yml: Lint/EndAlignment has the wrong namespace - should be Layout Error: The `Style/TrailingCommaInLiteral` cop no longer exists. Please use `Style/TrailingCommaInArrayLiteral` and/or `Style/TrailingCommaInHashLiteral` instead. (obsolete configuration found in .rubocop.yml, please update it) obsolete parameter MaxLineLength (for Style/IfUnlessModifier) found in .rubocop.yml `Style/IfUnlessModifier: MaxLineLength` has been removed. Use `Metrics/LineLength: Max` instead obsolete parameter MaxLineLength (for Style/WhileUntilModifier) found in .rubocop.yml `Style/WhileUntilModifier: MaxLineLength` has been removed. Use `Metrics/LineLength: Max` instead
houndci-bot
reviewed
Apr 12, 2018
houndci-bot
left a comment
houndci-bot
left a comment
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
.rubocop.yml: Lint/BlockAlignment has the wrong namespace - should be Layout
.rubocop.yml: Lint/BlockAlignment has the wrong namespace - should be Layout .rubocop.yml: Lint/DefEndAlignment has the wrong namespace - should be Layout .rubocop.yml: Lint/EndAlignment has the wrong namespace - should be Layout Error: The `Style/TrailingCommaInLiteral` cop no longer exists. Please use `Style/TrailingCommaInArrayLiteral` and/or `Style/TrailingCommaInHashLiteral` instead. (obsolete configuration found in .rubocop.yml, please update it) obsolete parameter MaxLineLength (for Style/IfUnlessModifier) found in .rubocop.yml `Style/IfUnlessModifier: MaxLineLength` has been removed. Use `Metrics/LineLength: Max` instead obsolete parameter MaxLineLength (for Style/WhileUntilModifier) found in .rubocop.yml `Style/WhileUntilModifier: MaxLineLength` has been removed. Use `Metrics/LineLength: Max` instead
houndci-bot
reviewed
Apr 12, 2018
houndci-bot
left a comment
houndci-bot
left a comment
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
.rubocop.yml: Lint/BlockAlignment has the wrong namespace - should be Layout
.rubocop.yml: Lint/BlockAlignment has the wrong namespace - should be Layout .rubocop.yml: Lint/DefEndAlignment has the wrong namespace - should be Layout .rubocop.yml: Lint/EndAlignment has the wrong namespace - should be Layout Error: The `Style/TrailingCommaInLiteral` cop no longer exists. Please use `Style/TrailingCommaInArrayLiteral` and/or `Style/TrailingCommaInHashLiteral` instead. (obsolete configuration found in .rubocop.yml, please update it) obsolete parameter MaxLineLength (for Style/IfUnlessModifier) found in .rubocop.yml `Style/IfUnlessModifier: MaxLineLength` has been removed. Use `Metrics/LineLength: Max` instead obsolete parameter MaxLineLength (for Style/WhileUntilModifier) found in .rubocop.yml `Style/WhileUntilModifier: MaxLineLength` has been removed. Use `Metrics/LineLength: Max` instead
houndci-bot
reviewed
Apr 12, 2018
houndci-bot
left a comment
houndci-bot
left a comment
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
.rubocop.yml: Lint/BlockAlignment has the wrong namespace - should be Layout
.rubocop.yml: Lint/BlockAlignment has the wrong namespace - should be Layout .rubocop.yml: Lint/DefEndAlignment has the wrong namespace - should be Layout .rubocop.yml: Lint/EndAlignment has the wrong namespace - should be Layout Error: The `Style/TrailingCommaInLiteral` cop no longer exists. Please use `Style/TrailingCommaInArrayLiteral` and/or `Style/TrailingCommaInHashLiteral` instead. (obsolete configuration found in .rubocop.yml, please update it) obsolete parameter MaxLineLength (for Style/IfUnlessModifier) found in .rubocop.yml `Style/IfUnlessModifier: MaxLineLength` has been removed. Use `Metrics/LineLength: Max` instead obsolete parameter MaxLineLength (for Style/WhileUntilModifier) found in .rubocop.yml `Style/WhileUntilModifier: MaxLineLength` has been removed. Use `Metrics/LineLength: Max` instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Фамилия Имя
Бондарева Юля
Email
y.d.bondareva@inbox.ru
Номер домашнего задания
2
Ссылка на видео с демо работы
https://www.youtube.com/watch?v=aN83EPtgqio
Комментарии
Ну, а музыку youtube запретил