homework 1 #771
homework 1 #771
Conversation
| width_element = rows.last.max.to_s.length + 1 | ||
| width_last_row = width_element * rows.last.length | ||
|
|
||
| rows.each.with_index do |row, row_number| |
There was a problem hiding this comment.
Inconsistent indentation detected.
|
|
||
| def print_triangle(rows)[] | ||
| width_element = rows.last.max.to_s.length + 1 | ||
| width_last_row = width_element * rows.last.length |
There was a problem hiding this comment.
Inconsistent indentation detected.
| end | ||
|
|
||
| def print_triangle(rows)[] | ||
| width_element = rows.last.max.to_s.length + 1 |
There was a problem hiding this comment.
Inconsistent indentation detected.
2018/Serg-Lapata/hw-1/task.rb
Outdated
| check_integer(int.to_i) | ||
| end | ||
|
|
||
| def print_triangle(rows)[] |
2018/Serg-Lapata/hw-1/task.rb
Outdated
| end | ||
|
|
||
| def check_integer(int) | ||
| int < 1 ? raise('Got invalid number') : int.positive? ? int : raise('Got invalid number') |
There was a problem hiding this comment.
Ternary operators must not be nested. Prefer if or else constructs instead.
Line is too long. [91/80]
2018/Serg-Lapata/hw-1/task.rb
Outdated
| end | ||
|
|
||
| def check_integer(int) | ||
| int.positive? ? int : raise('Got invalid number') |
There was a problem hiding this comment.
Use 2 (not 0) spaces for indentation.
2018/Serg-Lapata/hw-1/task.rb
Outdated
| end | ||
|
|
||
| def check_integer(int) | ||
| int.positive? ? int : raise('Got invalid number') |
There was a problem hiding this comment.
Use 2 (not 1) spaces for indentation.
| current_value = start_value | ||
| row = [current_value] | ||
| k = 1 | ||
| row_number.times do |
There was a problem hiding this comment.
а почему бы аналог k переменной не передать в блок? Ведь times это может и тогда этот вот k = 1 можно будет убрать
Xanderwot
left a comment
Xanderwot
left a comment
There was a problem hiding this comment.
Видео с демо работы прям не проверял видимо.
3 participants
Фамилия Имя
Сергей Лапата
Email
Sovichh@yandex.ru
Номер домашнего задания
1
Ссылка на видео с демо работы
https://www.youtube.com/watch?v=ecIWPzGEbFc