Impove tests for error messages in Array#pack, String#unpack #1313
+15
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trinistr
force-pushed
the
add-tests-for-pack-unknown-directives
branch
from
7900c25 to
c6aadbb
Compare
trinistr
changed the title
Member
|
Please take into account the following changes dba8426. |
Contributor
Author
|
I see, tests already exist, I've missed them. I will change this PR to an improvement in messages. |
trinistr
force-pushed
the
add-tests-for-pack-unknown-directives
branch
from
c6aadbb to
542c8d7
Compare
trinistr
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From #1216
Previously, 69634ef added tests, but the messages weren't full, and there was no test for a warning in
String#unpack.I've removed the comments, as the errors are no longer a future plan.