Nito #447
Closed
Nito #447
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…beeing reenable-d.
… looking indentaiton.
Enabled build matrix for GitHub Actions
Try to use rvm on GitHub Actions.
Cleanup gemspec
Make `PackageTask` be able to omit parent directory while packing files
Add order only dependency.
Signed-off-by: Takuya Noguchi <takninnovationresearch@gmail.com>
Signed-off-by: Takuya Noguchi <takninnovationresearch@gmail.com>
Signed-off-by: Takuya Noguchi <takninnovationresearch@gmail.com>
Remove bin/rdoc
Remove bin/rake
Remove bin/bundle
…-compat Apply RuboCop linting for Ruby 2.3
Signed-off-by: Takuya Noguchi <takninnovationresearch@gmail.com>
…-compat Update rubocop to work with Ruby 2.4 compatible
Signed-off-by: Takuya Noguchi <takninnovationresearch@gmail.com>
Signed-off-by: Takuya Noguchi <takninnovationresearch@gmail.com>
chore: fix typo in comments
Use 'test' as workflow name on Actions
Signed-off-by: Takuya Noguchi <takninnovationresearch@gmail.com>
docs: update CONTRIBUTING.rdoc
Signed-off-by: Takuya Noguchi <takninnovationresearch@gmail.com>
Add RuboCop job to Actions
Lock minitest-5.15.0 for Ruby 2.2
Lazily requiring it in this matter can break rake whenever a rake task limits access to the file system. For example: ```ruby task :default do Dir.chroot Dir.pwd end ``` One reason to lazily require this is to save on memory, but since Rake::Application appears to always use a thread pool (Rake::Application#run -> top_level -> run_with_threads -> thread_pool), it doesn't looks like lazily requiring actually saves memory in this case.
If the thread_pool does not already exist, there is no point in creating a thread pool just to join the threads in it. This is an alternative fix for #440.
Eagerly require set in thread_pool.rb
Avoid creating an unnecessary thread pool
Shows current maintainers to wider community contributors. Signed-off-by: Takuya Noguchi <takninnovationresearch@gmail.com>
Add credit for maintenance in Rake 12/13
Sh fully echoes commands which error exit
Correct RuboCop offenses
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
18 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hope it's done