[pull] master from launchbadge:master #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sqlx-core uses whoami to provide the fallback for postgres username. If not building postgres support, omit the dependency on whoami.
* Update rsa crate to 0.5 * Don't do pem decoding ourselves
* Append to existing RUSTFLAGS, instead of overwriting. * Assemble RUSTFLAGS correctly. Co-authored-by: Thomas Kintscher <thomas@flowciety.de>
…g. (#1587) * core/sqlite: Add special case for sqlcipher key pragma when connecting. * core/sqlite: Move std::fmt::Write import to module level.
…ser and database ordering (#1566) * fix(postgres): Fixes pgpass so it applies after parsing and matches usernames & databases correctly * chore: Updated unit test * refactor: Previous semantics of PgConnectOptions::default() * refactor: formatting
* Reimport Either used in Executor * Re-import sqlx-core * Update src/lib.rs Co-authored-by: Austin Bonander <austin.bonander@gmail.com> * Apply fmt Co-authored-by: Austin Bonander <austin.bonander@gmail.com>
* Postgres: Add test for array enum * Allow produces() to override type_info() as per doc * run cargo fmt
This commit fixes the array decoder to support custom types. The core of the issue was that the array decoder did not use the type info retrieved from the database. It means that it only supported native types. This commit fixes the issue by using the element type info fetched from the database. A new internal helper method is added to the `PgType` struct: it returns the type info for the inner array element, if available. Closes #1477
* feat(postgres): add an option to specify extra options ... ... this allow you to specify stuff like search path and statement timeouts etc. * feat(postgres): set options through setting run-time parameters * feat(postgres): use flat command-list instead of hashmap * feat(postgres): make the options taking parameters with `Display` trait
* Adds feature enabling Rustls usage rather than OpenSSL * Update sqlx-cli/Cargo.toml Removes extraneous openssl feature that slipped through Co-authored-by: Austin Bonander <austin.bonander@gmail.com> Co-authored-by: Austin Bonander <austin.bonander@gmail.com>
* fix(cli): change new `rustls` and `native-tls` features to use correct runtime feature * chore: upgrade SQLx crates to 0.5.10, upgrade all dependencies to latest versions chore(cli): upgraded `clap` to `3.0.0-rc.9` * fix(tests/sqlite): ignore `issue_1467()` as spuriously failing I'm well aware of the principle that a spuriously failing test is a failing test, but even though I have it outputting the seed used with a reproducible PRNG, I can't reproduce the failures locally, so 🤷. * chore: add CHANGELOG entry for 0.5.10
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
Adds a `target` field to the Postgres notice logs and filters based on that target, just like how the query logs do it.
typo fix
* Show failing test 0.002 will be encoded as 0.02 * The power calculation should depend on the offset of the digits
Fixes the build failures until 8.0.29 is released.
* sqlite: add test for concurrent table access (failing) * sqlite: implement unlock notification
…acros` (#1782) * refactor: Reuse a cached connection instead of always recreating for `sqlx-macros` * fix: Fix type inference issue when no database features used * refactor: Switch cached db conn to an `AnyConnection` * fix: Fix invalid variant name only exposed with features * fix: Tweak connection options for SQLite with `sqlx-macros` * fix: Remove read only option for SQLite connection * fix: Fix feature flags regarding usage of `sqlx_core::any`
Postgres arrays and records do not fully support custom types. When encountering an unknown OID, they currently default to using `PgTypeInfo::with_oid`. This is invalid as it breaks the invariant that decoding only uses resolved types, leading to panics. This commit returns an error instead of panicking. This is merely a mitigation: a proper fix would actually add full support for custom Postgres types. Full support involves more work, so it may still be useful to fix this immediate issue. Related issues: - #1672 - #1797
Sometimes people do a bad job of reading comprehension (see #1813). This rewords a little to be even more prescriptive about how to build in offline mode.
* changed [] access to .get() to return result instead of panic * changed error type to protocol err * fixed issue with comparing ref * cargo fmt Co-authored-by: Erik Rhodes <erik@space-nav.com>
From a formatting perspective, `Usage` is currently nested under `Install`. I think these would appropriately be siblings. This has the side benefit of making the headings under `Usage` more visually distinct from the rest of the content which I think makes it easier to read.
* query_as: don't stop stream after decoding error Fixes #1884 When a single row cannot be converted to the target type of query_as, it should not prevent the library user from accessing the other rows Otherwise, the user cannot access all query results in query_as. * use union in tests to maximize db compatibility
* reproduce incorrect nullability for materialized views * split ephemeral/index-only table handling from real table handling * add test for literal null, expect nullability to be identified from table information * gather interpreter state into a struct, no change in behaviour * prevent infinite loops that could arise once branching is supported * track nullability alongside the datatype instead of in a separate lookup * implement basic comprehension of branching opcodes * fix datatype calculation of aggregates which are never 'stepped' through * implement coroutine and return operations, including tracking of 'actual' integer value stored in the register by Integer/InitCoroutine/Yield operations. * strip unnecessary history field out * Modify variable test to expect bind-variable outputs to be nullable, rather than unknown * add partially commented-out union tests, simplify code to satisfy simplest union case * fix unit test incorrectly expecting primary keys to be implicitly not-null * add failing test for recursive tables * add logging of query explain plan * track explain plan execution history * broken RowData implementation (doesn't alias) * Implement OpenPseudo tables as an alias of a register value * fix comment * clean up logging code warnings * use cfg to omit QueryPlanLogger unless sqlite feature is used
* Fix typos * Update CHANGELOG.md Co-authored-by: Austin Bonander <austin.bonander@gmail.com> Co-authored-by: Austin Bonander <austin.bonander@gmail.com>
* added test for mssql ReturnValue * fixed warnings: unused import: `DataType`
When running `sqlx migrate info`, the applied migrations checksums are compared against the checksums of the local migration files. While the checksums of applied migrations are stored correctly in the database as sha384sum values, the `migrate info` command was incorrectly comparing these against the checksums of down-migrations in cases where reversible migrations are being used (e.g. when migrations end in `.up.sql` and `.down.sql`). This fixes the issue by skipping over any migrations with the `MigrationType::ReversibleDown` type, using the same idiom as is used when running migrations (with `migrate run`). Issue introduced in #1680 Partially resolves #1158
…`PgConnectOptions` (#1897) * Expose ConnectOptions * Expose PoolOptions
* Fixed leak of `Arc<SharedPool>` in `DecrementSizeGuard::cancel()` * Renamed `PoolOptions::connect_timeout` to `acquire_timeout` for clarity. * Fixed `/* SQLx ping */` showing up in Postgres query logs * Made `.close()` a regular function that returns a `Future` * Deleted deprecated method `PoolConnection::release()` * Document why connection might be dropped if `Pool::acquire()` is cancelled * Added connection metadata to pool lifecycle callbacks * Improved guarantees for `min_connections` * Fixed `num_idle()` to not spin forever at high load * Improved documentation across the `pool` module
* preparing 0.6.0 release * run `cargo update` (not `upgrade`)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )