Skip to content

Tags: rizalgowandy/copilot-cli

Tags

v1.11.0

Toggle v1.11.0's commit message

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
fix: use role ARN (not name) for execution/task role in ECS task defs (

…aws#2887)

Using the role name in the ECS task definition results in CloudFormation stack drift.  ECS returns the fully-qualified ARN when describing the task def, which fails the comparison to the stack template's value.

Example drift seen in the CFN console for a Copilot-created service stack:

```
Expected:
  "ExecutionRoleArn": "proton-pilot-example-test-front-end-ExecutionRole-1CY6ZXWZU4YQF",
  "TaskRoleArn": "proton-pilot-example-test-front-end-TaskRole-1NMILHSCBDBTT"

Actual:
  "ExecutionRoleArn": "arn:aws:iam::123456789012:role/proton-pilot-example-test-front-end-ExecutionRole-1CY6ZXWZU4YQF",
  "TaskRoleArn": "arn:aws:iam::123456789012:role/proton-pilot-example-test-front-end-TaskRole-1NMILHSCBDBTT"
```

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.

v1.10.1

Toggle v1.10.1's commit message

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
chore: PR template to specify the correct license (aws#2801)

<!-- Provide summary of changes -->

This fixes the PR template to specify the Apache 2.0 License rather than leaving it the default "under the terms of your choice". 

<!-- Issue number, if available. E.g. "Fixes #31", "Addresses #42, 77" -->

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

v1.10.0

Toggle v1.10.0's commit message

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
chore: format recommended actions slightly more inward (aws#2792)

🥺

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

v1.9.0

Toggle v1.9.0's commit message

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
chore: adds queue uri json generation (aws#2667)

Adds generation of COPILOT_QUEUE_URIS with worker services.

Addresses aws#2550

v1.8.3

Toggle v1.8.3's commit message

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
chore(stack): error if target sidecar container has no port (aws#2571)

<!-- Provide summary of changes -->
After aws#2565, it is possible that a sidecar container has no port open. However, we should error out early if that sidecar container is the target container for LB.
<!-- Issue number, if available. E.g. "Fixes #31", "Addresses #42, 77" -->

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

v1.8.2

Toggle v1.8.2's commit message

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
fix(stream): wrap close done ch with sync.Once (aws#2537)

Today, `stream.Stream` is structured as:
```go
case <-streamer.Done():
  // call Close()
case <-time.After(fetchDelay):
  // call Fetch()
```
The problem is that it's possible that the `Done()` event is triggered at
the same time as `time.After(fetchDelay)` and in that scenario the
behavior is undeterministic.
It's possible that we call `Fetch` a second time. For the ECS deployment
streamer, this means that we would previous close the `s.done` channel
twice. Wrapping the call with a `sync.Once` removes this concern.


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

v1.8.1

Toggle v1.8.1's commit message

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
docs: update 'guides' pages with new blog posts, videos, sample repos (

…aws#2497)



By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

v1.8.0

Toggle v1.8.0's commit message

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
test: stub AreCredsFromEnvVars in app init to speed tests by 70s (aws…

…#2465)


🤦 Previously, we were calling sessions.AreCredsFromEnvVars in our tests
which would timeout after 10s:
https://github.com/aws/copilot-cli/blob/f2f0ee317e01b9da85ab72ecd64481c10658cd05/internal/pkg/aws/sessions/sessions.go#L28

Since the test TestInitAppOpts_Ask has 7 testcases it would take 70s to
test the cli package. With this one weird trick™️  and replacing the
functional call with a fake, we speed up our tests by 70s.


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

v1.7.1

Toggle v1.7.1's commit message

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
chore: add alias to the URI and listener rule (aws#2320)

<!-- Provide summary of changes -->
Part of aws#1188. Preceding PR aws#2315. This PR:
- add alias to the URI
- add alias to the listener rule
- enable path routing for HTTPS
- move stack related behaviors in `describe` to `describe/stack` pkg
<!-- Issue number, if available. E.g. "Fixes #31", "Addresses #42, 77" -->

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

v1.7.0

Toggle v1.7.0's commit message

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
chore: fix listing services and jobs in an environment (aws#2345)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.