Travel to Mars Example #13
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephsingler
suggested changes
May 21, 2018
stephsingler
left a comment
stephsingler
left a comment
There was a problem hiding this comment.
please submit a clean pull request with just space travel to mars file. You have 3 other projects attached to this PR
stephsingler
suggested changes
May 29, 2018
stephsingler
left a comment
stephsingler
left a comment
There was a problem hiding this comment.
Please submit a clean pull request before i can grade. There are 4 files in this PR and there should only be one.
reneemeyer
suggested changes
May 31, 2018
reneemeyer
left a comment
reneemeyer
left a comment
There was a problem hiding this comment.
See comments below. Please don't merge until you clean up this pull request. There are 4 changed files and there should only be one.
|
|
||
| } | ||
| missionStatement() { | ||
| return this.ability; |
There was a problem hiding this comment.
this is almost correct, however it doesn't satisfy the tests, the ability is only returned if there is a crew member on the ship
| this.ship = ship; | ||
| } | ||
| enterShip(ship) { | ||
| this.ship = ship; |
There was a problem hiding this comment.
the crew member needs to be entered into the ship's crew
| return this.ship; | ||
| } | ||
| } | ||
| let mav = new Ship('Mars Ascent Vehicle', 'MAV', 'Ascend into low orbit'); |
| } | ||
| } | ||
| let mav = new Ship('Mars Ascent Vehicle', 'MAV', 'Ascend into low orbit'); | ||
| let hermes = new Ship('Hermes', 'Main Ship', 'Interplanetary Space Travel'); |
| mav.crew.push(1); | ||
|
|
||
| // Created new object of CrewMember for test purposes. | ||
| let crewMember1 = new CrewMember('Rick Martinez', 'pilot', 'chemistry'); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checkpoint Rubric
This is the rubric that your instructor will use to grade your checkpoints. Please do not edit.
Checkpoint 1
Checkpoint 2
Checkpoint 3