Draft
Conversation
Jade-GG
previously approved these changes
Jul 24, 2025
Member
Author
|
I've heavily optimised the query now, due to no longer using where not and concat it can take full advantage of the indexes. See the explain of a query heavily dependent on this feature:
As you can see every subquery uses the index. |
28 tasks
Member
|
Do we need some unit tests for this so we're sure the results are the same? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for a combined
uniquePerStoreKeyNot every database table has a single field which is duplicate with multiple stores, but unique otherwise.
An example of what this could work with before is the
catalog_product_entity_media_gallery_valuevalue_idis completely unique except forstore_idwhere it can have the samevalue_idAn example where this wouldn't work before is the
catalog_product_entity_varchartable.Where an entry is unique per store only when
attribute_idandentity_idare combined. Since anattributecan have values attached and a product can also have multiple values attached, but a product cannot have multiple values of the same attribute attached.An example of it's usage in that case would be: