Skip to content

https URLs#2091

Closed
hrbrmstr wants to merge 0 commit intor-lib:masterfrom
hrbrmstr:master
Closed

https URLs#2091
hrbrmstr wants to merge 0 commit intor-lib:masterfrom
hrbrmstr:master

Conversation

@hrbrmstr
Copy link
Contributor

NOTE: I did not change the domain or path, just migrated http:// to https:// for URLs when I noticed that a few key ones (such as submitting to CRAN) would enable [MP]ITM attacks.

@jimhester
Copy link
Member

Thanks for paying attention to this!
Can you please add a bullet to NEWS? It should briefly describe the change and end with (@yourname, #issuenumber), then I would be happy to merge.

@hrbrmstr
Copy link
Contributor Author

hrbrmstr commented Aug 19, 2019 via email

NEWS.md Outdated
* `test_file()` and `test_coverage_file()` now work with C
and C++ files in the src/ directory as well.

*
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like maybe an extraneous bullet got added here.

@jimhester
Copy link
Member

Gah, I seem to have botched this PR, merged it manually at ddd0581

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants