Remove obsolete check from circuit.earliest_available_moment. #7805
+3
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The conditions in _can_add_op_at are already checked in the while loop. There is no AbstractDevice so I removed the check and the note. I also handled the case when end_moment_index > len(self._moments). earliest_available_moment references from insert are guaranteed to have end_moment_index between 0 and len(self._moments), but earliest_available_moment is exposed publicly as well.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7805 +/- ##
=======================================
Coverage 99.57% 99.57%
=======================================
Files 1102 1102
Lines 98638 98638
=======================================
Hits 98218 98218
Misses 420 420 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
pavoljuhas
approved these changes
Dec 15, 2025
Collaborator
pavoljuhas
left a comment
pavoljuhas
left a comment
There was a problem hiding this comment.
Nice, thank you for cleaning this up!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The conditions in
_can_add_op_atare already checked in the while loop. There is noAbstractDeviceso I removed the check and the note.I also handled the case when
end_moment_index > len(self._moments).earliest_available_momentreferences frominsertare guaranteed to haveend_moment_indexbetween0andlen(self._moments), butearliest_available_momentis also exposed publicly.