Skip to content

Fix parent resource name used to call ListQuantumProcessorConfigs #7802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hoisinberg merged 2 commits into from
Dec 15, 2025
Merged

Fix parent resource name used to call ListQuantumProcessorConfigs #7802

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
db6a944
Fix parent resource name used to call ListQuantumProcessorConfigs
hoisinberg Dec 12, 2025
6d7ad99
Linting and formatting fixes
hoisinberg Dec 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions cirq-google/cirq_google/engine/engine_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1205,12 +1205,14 @@ async def get_quantum_processor_config_async(
EngineException: If the request to get the config fails.
"""
try:
name = _quantum_processor_revision_path(
config_revision = _quantum_processor_revision_path(
project_id=project_id,
processor_id=processor_id,
device_config_revision=device_config_revision,
)
request = quantum.GetQuantumProcessorConfigRequest(name=f'{name}/{config_name}')
request = quantum.GetQuantumProcessorConfigRequest(
name=f'{config_revision}/configs/{config_name}'
)
return await self._send_request_async(
self.grpc_client.get_quantum_processor_config, request
)
Expand Down Expand Up @@ -1303,11 +1305,11 @@ def _quantum_processor_revision_path(
) -> str:
processor_resource_name = _processor_name_from_ids(project_id, processor_id)
if isinstance(device_config_revision, Snapshot):
return f'{processor_resource_name}/configSnapshots/{device_config_revision.id}/configs'
return f'{processor_resource_name}/configSnapshots/{device_config_revision.id}'

default_run_name = 'default'
run_id = device_config_revision.id if device_config_revision else default_run_name
return f'{processor_resource_name}/configAutomationRuns/{run_id}/configs'
return f'{processor_resource_name}/configAutomationRuns/{run_id}'


def _date_or_time_to_filter_expr(param_name: str, param: datetime.datetime | datetime.date):
Expand Down
6 changes: 2 additions & 4 deletions cirq-google/cirq_google/engine/engine_client_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1880,9 +1880,7 @@ def test_list_quantum_processor_configs_from_run_name(client_constructor, defaul
project_id = "test_project_id"
processor_id = "test_processor_id"
run = Run(id="test_run_name")
resource_name = (
f'projects/{project_id}/processors/{processor_id}/configAutomationRuns/{run.id}/configs'
)
resource_name = f'projects/{project_id}/processors/{processor_id}/configAutomationRuns/{run.id}'

expected_results = [
quantum.QuantumProcessorConfig(
Expand Down Expand Up @@ -1913,7 +1911,7 @@ def test_list_quantum_processor_configs_from_snapshot(client_constructor, defaul
processor_id = "test_processor_id"
snapshot = Snapshot(id="test_snapshot_id")
snapshot_resource_name = (
f'projects/{project_id}/processors/{processor_id}/configSnapshots/{snapshot.id}/configs'
f'projects/{project_id}/processors/{processor_id}/configSnapshots/{snapshot.id}'
)

expected_results = [
Expand Down
2 changes: 1 addition & 1 deletion cirq-google/cirq_google/engine/engine_processor_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1180,7 +1180,7 @@ def test_list_configs_from_snapshot(client):
snapshot = Snapshot(id="test_snapshot_id")
config_1 = "test_config_1"
config_2 = "test_config_2"
name_prefix = f'projects/{project_id}/processors/{processor_id}/configSnapshots/{snapshot.id}/'
name_prefix = f'projects/{project_id}/processors/{processor_id}/configSnapshots/{snapshot.id}'

quantum_configs = [
quantum.QuantumProcessorConfig(name=f'{name_prefix}/configs/{config_1}'),
Expand Down
Loading