-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Fix inconsistency between qubits measurements in readout circuits and real measurement circuits #7801
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7801 +/- ##
==========================================
- Coverage 99.57% 99.56% -0.01%
==========================================
Files 1102 1102
Lines 98638 98638
==========================================
- Hits 98218 98213 -5
- Misses 420 425 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@eliottrosenberg Can you take a look at this? Thank! |
eliottrosenberg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks, @ddddddanni!
NoureldinYosri
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add a test
pavoljuhas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please add a test that will fail before and pass after this PR?
Also, looking at the code we can avoid some complicated casting by using a separate variable for the sweep vs no-sweep cases. Please see this patch - pr7801-with-less-casting.patch.txt (can be applied with git apply PATCH_FILE).
There is an inconsistency on qubits measurements in readout circuits and measurement circuits. The measurement circuits always measure the full circuit set of qubits, while the qubits being measured in readout/calibration circuits are based only on the qubits present in the Pauli strings.
In this PR, I have updated the circuit generation to only measure the qubits relevant to the Pauli group being processed.