(1/2) Combine Pauli measurements and postselection #7746
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eliottrosenberg
requested changes
Nov 17, 2025
Collaborator
Author
Done! |
eliottrosenberg
approved these changes
Dec 10, 2025
Collaborator
eliottrosenberg
left a comment
eliottrosenberg
left a comment
There was a problem hiding this comment.
One small nit, otherwise LGTM. Thanks!
|
|
||
| circuit: circuits.FrozenCircuit | ||
| pauli_strings: list[list[ops.PauliString]] | ||
| postselection_symmetries: list[tuple[ops.PauliString | ops.PauliSum, int]] |
Collaborator
There was a problem hiding this comment.
Can we have this default to an empty list? That way users don't need to enter anything for postselection_symmetries if they don't want to postselect.
NoureldinYosri
approved these changes
Dec 11, 2025
| """ | ||
|
|
||
| circuit: circuits.FrozenCircuit | ||
| pauli_strings: list[list[ops.PauliString]] |
Collaborator
There was a problem hiding this comment.
since this is a frozen class, use tuple instead
| all_qubits: list[ops.Qid] | frozenset[ops.Qid], | ||
| ) -> bool: | ||
| """Checks if a Pauli sum and a Pauli string are Qubit-Wise Commuting.""" | ||
| for pauli_sum_term in pauli_sum: |
Collaborator
There was a problem hiding this comment.
reuse the _are_two_pauli_strings_qubit_wise_commuting method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I split this #7492 giant PR into smaller pieces for easier review.
This PR: