Add version 2 support for Float8StaticActivationFloat8WeightConfig #3509
+158
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: att, this is a prototype feature until we see wider adoption. only per tensor and per row for both activation and weight is supported. Test Plan: python test/prototype/test_float8_static.py Reviewers: Subscribers: Tasks: Tags:
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/3509
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New Failures, 1 Unrelated FailureAs of commit f96600a with merge base 1f9bfd7 ( NEW FAILURES - The following jobs have failed:
BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
vkuzo
reviewed
Dec 18, 2025
| hp_value_ub: Optional[float] = None, | ||
| kernel_preference: KernelPreference = KernelPreference.AUTO, | ||
| act_quant_kwargs: Optional[QuantizeTensorToFloat8Kwargs] = None, | ||
| scale: Optional[torch.Tensor] = None, |
Contributor
There was a problem hiding this comment.
why do we need both scale and act_scale here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
att, this is a prototype feature until we see wider adoption. only per tensor and per row for both activation and weight is supported.
Test Plan:
python test/prototype/test_float8_static.py
Reviewers:
Subscribers:
Tasks:
Tags: