Raise RelationWithoutDenotationError when parse and found relation without denotations #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhq-boiler
force-pushed
the
raise-relation-without-denotation-error
branch
4 times, most recently
from
022b4b1 to
0111237
Compare
dhq-boiler
force-pushed
the
raise-relation-without-denotation-error
branch
from
0111237 to
deb5fc2
Compare
dhq-boiler
force-pushed
the
raise-relation-without-denotation-error
branch
from
30f2ee5 to
03680c5
Compare
ledsun
reviewed
Aug 4, 2025
This reverts commit 84e9340.
ledsun
approved these changes
Aug 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概要
SimpleInlineTextAnnotation.parse での処理時にデノテーションを伴わないリレーションを見つけた時に、
RelationWithoutDenotationErrorを上げるようにしました。またこれに伴い、既存のテストを修正しました。