Skip to content

Conversation

@fmoo
Copy link

@fmoo fmoo commented Sep 16, 2011

This change adds a new attribute to the Response objects,
status_msg. This typically returns something like "OK"
for 200 responses or "Not Found" for 404 responses.

The status message can provide some additional semantic information
about the response outside of the response body and response headers.

@fmoo
Copy link
Author

fmoo commented Sep 21, 2011

Is this good? Or should I squash these revisions together?

@fmoo fmoo closed this Sep 21, 2011
@fmoo fmoo reopened this Sep 21, 2011
@kennethreitz
Copy link
Contributor

Sorry for the delay!

I'm torn about adding this in right now. I'm currently working at porting the entire backend of Requests to urllib3. part of that will be to give the response a simple reference to the original httplib response object w/ r.raw. With that, the status_msg will be available.

@fmoo
Copy link
Author

fmoo commented Sep 21, 2011

Yeah, I saw poster removal was targeting 0.8 and figured this might be good to have for another 0.6 or an 0.7 release in the meantime.

If urllib3 is around the corner and/or the api's (r.raw.status_msg vs. r.status_msg) won't be compatible then you probably shouldn't take this.

@kennethreitz
Copy link
Contributor

Closing, but I'll add you to the contributors list. If the urllib3 integration falls through (doubtful), I'll def add this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants