Skip to content

[PRODUCT-CREATOR] Concurrently creating firebase users of the same email succeeds - see issue #14 #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
provisota wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[PRODUCT-CREATOR] Concurrently creating firebase users of the same email succeeds - see issue #14 #95

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions firebase_admin/auth.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -422,7 +422,7 @@ def list_users(page_token=None, max_results=_user_mgt.MAX_LIST_USERS_RESULTS, ap
return client.list_users(page_token=page_token, max_results=max_results)


def create_user(**kwargs): # pylint: disable=differing-param-doc
def create_user(**kwargs): # pylint: disable=differing-param-doc
"""Creates a new user account with the specified properties.

Args:
Expand All @@ -447,7 +447,16 @@ def create_user(**kwargs): # pylint: disable=differing-param-doc
ValueError: If the specified user properties are invalid.
FirebaseError: If an error occurs while creating the user account.
"""
app = kwargs.pop('app', None)
# Check for existing user by email before creating a new user
email = kwargs.get('email')
if email:
try:
if client.get_user_by_email(email=email):
raise _auth_utils.EmailAlreadyExistsError(f"User with email {email} already exists.")
except _auth_utils.UserNotFoundError:
pass # No user exists with the given email, safe to proceed
if email and client.get_user_by_email(email=email):
raise _auth_utils.EmailAlreadyExistsError(f"User with email {email} already exists.")
client = _get_client(app)
return client.create_user(**kwargs)

Expand Down