Skip to content

Fix for task_queue.enqueue auth race condition #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
provisota wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix for task_queue.enqueue auth race condition #88

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 15 additions & 3 deletions firebase_admin/_http_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,9 +132,21 @@ class call this method to send HTTP requests out. Refer to
if 'timeout' not in kwargs:
kwargs['timeout'] = self.timeout
kwargs.setdefault('headers', {}).update(METRICS_HEADERS)
resp = self._session.request(method, self.base_url + url, **kwargs)
resp.raise_for_status()
return resp

for attempt in range(2): # Retry up to 2 times for transient auth errors
try:
resp = self._session.request(method, self.base_url + url, **kwargs)
resp.raise_for_status()
return resp
except requests.exceptions.HTTPError as http_err:
if resp.status_code in [400, 401, 403] and attempt == 0:
logger.warning(
"Transient auth error detected (status %d). Retrying...",
resp.status_code
)
self._session.credentials.refresh(google_auth_requests.Request())
else:
raise

def headers(self, method, url, **kwargs):
resp = self.request(method, url, **kwargs)
Expand Down