Enhancement from other scripts influence #16
Conversation
Using local function each() to prevent consequenses of Array.prototype.each() replacing. It happens when prototype.js is using with mootools.js for example. Basic situation when there is an error: <script type="text/javascript" src="http://ajax.googleapis.com/ajax/libs/prototype/1.7.0.0/prototype.js"></script> <script type="text/javascript" src="http://ajax.googleapis.com/ajax/libs/mootools/1.11/mootools.js"></script> <script type="text/javascript"> var justArray = ["A", "B"]; var elementFromArray = "A"; var check = function(value) { return value === elementFromArray; }; console.log(justArray.some(check)); </script> This problem arise from Array.prototype.each = Array.prototype.forEach; in mootools.js and from using this property in Enumerable: local one handles exceptions, native does not do it. Thus all(), every(), any(), some(), detect(), include() properties are broken when they throw exception. This patch solve the problem by using local each().
|
Sorry for leaving this open for so long. I'm intentionally choosing not to do this. I want users to be able to redefine (See also dom.js: It's true that this lets another script maliciously (or just accidentally) screw up other |
2 participants
There is local function each() in Enumerable() which is preferable to use in other functions. The commit provides solving the problem of Array.prototype.each() replacing between including prototype.js and using all(), every(), any(), some(), detect(), include() properties.