Skip to content

Conversation

@bpceee
Copy link
Contributor

@bpceee bpceee commented Jan 20, 2015

add Popular search engines' spiders user-agent list

@gillesdemey
Copy link

Can anyone have a look at this PR?

@thoop
Copy link
Contributor

thoop commented Feb 13, 2015

Sorry for the delay!

Adding .woff and .tff is good, but your isRobot function is already handled by the prerender.crawlerUserAgents check. Is there a reason you duplicated that logic?

Also, the user agent example you added contains Googlebot, which doing a user agent check on Googlebot will get you penalized for cloaking. You should only check for user agents that do not support the escaped fragment protocol.

@bpceee
Copy link
Contributor Author

bpceee commented Feb 18, 2015

@thoop
Sorry, You are right, the isRobot function is duplicated, I didn't find prerender.crawlerUserAgents before.
And many thanks for your suggestions.

@homeyer
Copy link
Contributor

homeyer commented Jul 4, 2015

@bpceee, want to pull the .woff and .ttf changes into a separate PR, or remove the other pieces from this PR?

@bpceee
Copy link
Contributor Author

bpceee commented Jul 5, 2015

@homeyer, better remove the other pieces from this PR, but how to do it?

@homeyer
Copy link
Contributor

homeyer commented Jul 5, 2015

git reset HEAD~2 --hard to remove the last two commits, and then git push -f to your fork.

@homeyer
Copy link
Contributor

homeyer commented Jul 5, 2015

Went ahead and opened a new PR (#74), I'll merge tonight after the tests pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants