Skip to content

completed assignment 2#2

Open
pradziie wants to merge 1 commit intomainfrom
assignment-2
Open

completed assignment 2#2
pradziie wants to merge 1 commit intomainfrom
assignment-2

Conversation

@pradziie
Copy link
Owner

@pradziie pradziie commented Sep 4, 2025

What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)

completed assignment

What did you learn from the changes you have made?

Right now, the simpler the better

Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?

I was playing with:

  1. a nested statement to ensure the paths part of the code runs on both Windows and Mac
  2. trying to use relative paths
    However, I gave up and decided to just stick to the instructions as it would add variables, and because i didn't really understand it completely. Decided not to overcomplicate.

Were there any challenges? If so, what issue(s) did you face? How did you overcome it?

  1. Yes, with relative paths. Used absolute paths for files instead.
  2. Part 3 seemed like something that would require a lot of code. Was shocked when realized how short and simple it might have to be. As long as it's correct. I hope that it's correct ._.

How were these changes tested?

  1. Played around in my assignment 2 aux file which I'm not adding here.
  2. Also, tested the other two string selectors ('max' and 'min'). They seem to work correctly.

A reference to a related issue in your repository (if applicable)

Assignment 2, Part 1.

Checklist

  • [*] I can confirm that my changes are working as intended

Copy link

@xindizhang xindizhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, and excellent comments in your code! No further changes needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants