Skip to content

Assignment 1#1

Open
pradziie wants to merge 8 commits intomainfrom
assignment-1
Open

Assignment 1#1
pradziie wants to merge 8 commits intomainfrom
assignment-1

Conversation

@pradziie
Copy link
Owner

What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)

Updated assignment_1.ipynb

What did you learn from the changes you have made?

  1. I learned the basics of how to manipulate strings and to verify them
  2. I learned that I really need to learn proper readable syntax more
  3. I learned that I should go back to managing repos with Git Bash more because VS code is so good and convenient that I'll forget how to use a terminal if I don't

Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?

Yes, I was playing with adding text strings in addition to booleans in Part 2. However, after struggling with properly showing both, I decided to just stick to the original instructions (to show only the True or False booleans).

Were there any challenges? If so, what issue(s) did you face? How did you overcome it?

  1. Took me some time to get to the .lower and sort() methods to create the anagram checker.
    Had to go over the common string manipulation methods. Only saw .lower mentioned once in the notes / live code, so didn't catch it at first and had to search for common string manipulation methods.
  2. Wondered why we started with the non-case-sensitive anagram, given that the case-sensitive one would've been simpler.
    Completing Part 2 answered that question for me.

How were these changes tested?

I tested some of them in the assignment file, and some of them in a separate aux .ipynb file to be safe (did not commit that file, and kept it in a separate temp folder outside the repo). This is because I did not want to add or remove test cells in the assignment_1 file while playing around.

A reference to a related issue in your repository (if applicable)

All in assignment_1.ipynb

Checklist

  • [*] I can confirm that my changes are working as intended

Copy link

@juliagallucci juliagallucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're almost there! For part A, you should be returning a Boolean (True/False). For part B, one note for improvement, you don’t need to explicitly use an if/else to return True or False- you can just return the comparison directly. Please revise

Copy link

@juliagallucci juliagallucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants