Open
Conversation
Add live code 08/19/2025
Upload live coding notebook 08/20/2025
Upload live code 08/21/2025
juliagallucci
suggested changes
Aug 25, 2025
juliagallucci
left a comment
There was a problem hiding this comment.
You're almost there! For part A, you should be returning a Boolean (True/False). For part B, one note for improvement, you don’t need to explicitly use an if/else to return True or False- you can just return the comparison directly. Please revise
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
Updated assignment_1.ipynb
What did you learn from the changes you have made?
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
Yes, I was playing with adding text strings in addition to booleans in Part 2. However, after struggling with properly showing both, I decided to just stick to the original instructions (to show only the True or False booleans).
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
Had to go over the common string manipulation methods. Only saw .lower mentioned once in the notes / live code, so didn't catch it at first and had to search for common string manipulation methods.
Completing Part 2 answered that question for me.
How were these changes tested?
I tested some of them in the assignment file, and some of them in a separate aux .ipynb file to be safe (did not commit that file, and kept it in a separate temp folder outside the repo). This is because I did not want to add or remove test cells in the assignment_1 file while playing around.
A reference to a related issue in your repository (if applicable)
All in assignment_1.ipynb
Checklist