SQL Injection #1
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code was corrected by replacing the dynamically generated SQL queries with prepared statements. This change addresses the SQL Injection vulnerability by ensuring that user inputs are properly parameterized and not directly concatenated into SQL strings.
Use of Prepared Statements:
PreparedStatementclass is used to create SQL statements with placeholders (?) for parameters. This prevents SQL injection by separating SQL logic from data.ACCOUNTID,DATE,TYPE, andAMOUNT. The actual values are set using thesetInt,setString, andsetDoublemethods.Parameter Binding:
Separate Statements for Different Operations:
Consistent Use of Prepared Statements:
By implementing these changes, the code now safely handles user inputs, preventing attackers from injecting malicious SQL code. This significantly reduces the risk of unauthorized data access and manipulation.
Created by: plexicus@plexicus.com