cleanup code #1547
Merged
cleanup code #1547
+209
−247
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
aleksandy
commented
Jan 10, 2026
aleksandy
commented
- use primitive type instead of wrapper;
- close keystore after loading;
- extract methods and constants for readability;
- X509TrustManager#getAcceptedIssuers() must return non null value.
* use primitive type instead of wrapper; * close keystore after loading; * extract methods and constants for readability; * X509TrustManager#getAcceptedIssuers() must return non null value.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Contributor
Author
|
@xael-fry, could you review my PR? |
Contributor
Author
|
@asolntsev, could you review my PR? |
asolntsev
approved these changes
Jan 11, 2026
xael-fry
approved these changes
Jan 18, 2026
Member
|
Merged in master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.