Bugfix stable 3 4 0 143 fix recaptcha on login#144
Open
jonasraoni wants to merge 2 commits intopkp:stable-3_4_0from
Open
Bugfix stable 3 4 0 143 fix recaptcha on login#144jonasraoni wants to merge 2 commits intopkp:stable-3_4_0from
jonasraoni wants to merge 2 commits intopkp:stable-3_4_0from
Conversation
jonasraoni
force-pushed
the
bugfix-stable-3_4_0-143-fix-recaptcha-on-login
branch
from
e3b7ab3 to
5bbb3f2
Compare
jonasraoni
force-pushed
the
bugfix-stable-3_4_0-143-fix-recaptcha-on-login
branch
from
5bbb3f2 to
4f92118
Compare
|
|
||
| {* recaptcha spam blocker *} | ||
| {if $recaptchaPublicKey} | ||
| {if $recaptchaPublicKey && \PKP\config\Config::getVar('captcha', 'captcha_on_login')} |
Member
There was a problem hiding this comment.
Similar to the PR on the pragma theme - Perhaps the captcha_on_login and captcha_on_register (below) should also be a variable passed from ImmersionThemePlugin.inc.php instead of checking the config in the templates?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.