Merged
Conversation
The pytz library returns the real date and time of the selected timezone in a consistent and predictable way - so I migrated to using that library. I think I managed to catch all the instances where the date library was being used. All the tests are passing so far.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This release has a few neat additions:
Access reviews are the most boring part of my job, so automating them (or at least making them less painful) makes sense for me. Main use case is to get a list of users from github or any other api, paste the json in Opsdeck and compare them with the internal users list with a single click, specifying which columns to compare.
While you can definitely do this on excel, a xls sheet won't send you alerts, or let you create an incident ticket with a single click, so this will save me hours, and I hope it saves time to others, too.