mow plant harvest blueprint with dynamic tractor data

[pocikerim]

No description provided.

[fr1jo]

SiloHelpers uses getBeanToken() a lot as well. can we also make that a immutable variable?

[pocikerim]

@fr1jo for SiloHelpers here: c7ef6c0

[fr1jo]

review II

[fr1jo]

review III. needs 1 more small-medium refactor, but 95% of the way there!

[fr1jo]

the OperatorHarvestData and UserFieldHarvestResults struct has similar data types. any chance this can be combined and used as one?

[fr1jo]

not applicable anymore from another comment. UserFieldHarvestResults will now return an additional parameter.

[fr1jo]

you can save an instantiation here by setting the output of beanstalk.harvest() to vars.totalHarvestedBeans

[fr1jo]

i incorrectly thought this was resolved. given that the tractor operator is already setting the operator data at the harvest key + field id, asking the operator to provide the field id is redundant.

lets rework this so that the operator only needs to set the plots in here. you can remove the require statement from R374 once you do so.

[fr1jo]

one last optimization. Currently, what we do in this function is set the harvestable plots for a given fieldId to 0, If the operator didn't provide the plots (i.e there are no harvestable plots). userFieldHarvestResults is then propagated up to _getAndValidateUserState and vars.userFieldHarvestResults.

lets do the following refactors.

1. instantiate a counter, signifying the final length ofuserFieldHarvestResults. if operatorData.length == 0 for a given fieldId, decrement this counter. Once you finish, you can reduce the length of userFieldHarvestResults using assembly.

something like this:

        userFieldHarvestResults = new UserFieldHarvestResults[](fieldHarvestConfigs.length);
        uint256 index;
        for (uint256 i = 0; i < fieldHarvestConfigs.length; i++) {
            uint256 fieldId = fieldHarvestConfigs[i].fieldId;

            // Read operator-provided data from transient storage
            bytes memory operatorData = beanstalk.getTractorData(HARVEST_DATA_KEY + fieldId);

            // If operator didn't provide data for this field, treat as no harvestable pods
            if (operatorData.length == 0) {
                continue;
            }

            // Decode operator-provided harvest data
            OperatorHarvestData memory harvestData = abi.decode(
                operatorData,
                (OperatorHarvestData)
            );

            // Verify operator provided data for the correct field
            require(harvestData.fieldId == fieldId, "MowPlantHarvestBlueprint: Field ID mismatch");

            // Use operator data - validation happens in harvest() call
            userFieldHarvestResults[index] = UserFieldHarvestResults({
                fieldId: fieldId,
                harvestablePlots: harvestData.harvestablePlotIndexes
            });
            index++;
        }

        assembly { 
            mstore(userFieldHarvestResults, index)
        }

2. update _getAndValidateUserState to omit shouldHarvest. this is redundant as all the information we need is in userFieldHarvestResults in order to know whether we should harvest (if userFieldHarvestResults.length != 0). you can also remove shouldHarvest from the localVars now as well as remove shouldHarvest = _checkHarvestConditions(userFieldHarvestResults);

3. in the if (vars.shouldHarvest) { block, you can now omit the if (vars.userFieldHarvestResults[i].harvestablePlots.length == 0) continue; check. Given that the userFieldHarvestResults index doesn't match with fieldHarvestConfigs now, I would update the UserFieldHarvestResults struct to include the minHarvestAmount as well. You'll need to slightly refactor require( harvestedBeans >= params.mowPlantHarvestParams.fieldHarvestConfigs[i].minHarvestAmount, "MowPlantHarvestBlueprint: Harvested amount below minimum threshold" ); to use the value in userFieldHarvestResults.

[fr1jo]

you need to add back the previous logic where we only perform this special logic if the token they want to tip from is the pinto token. Unclear why that was removed. should be able to copy paste this directly from a previous commit.

905d012#diff-00263ed26b5d1f84db9835491aa9430aa4d226b0919134fd66fef150d7ad8c1aL594-L624

also, in. _resolvedSourceIsBean, if (sourceTokenIndices.length == 0) return false; is redundant. _validateSourceTokens already checks that sourceTokenIndices.length > 0.

[fr1jo]

twa needs to be capitalized here (minTwaDeltaB)