Added better node position logging#1192
Closed
TeemoKill wants to merge 0 commit intopingcap:masterfrom
Closed
Conversation
Contributor
|
Hi @TeemoKill, would you like to explain why we need this feature? Did you encounter any problems? |
Member
|
@TeemoKill: PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Yifan Luo seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Maybe #910 -> How do I get the position of an AST node.
The previous solution logged the starting offset of the original text,
this pull request added more detailed position information to ast.Node
What is changed and how it works?
Moved the struct
Posfromparser/lexer.gointoparser/ast/ast.goAdded 2 methods
to the interface
ast.NodeCheck List
Tests
Code changes
Side effects
Related changes
N/A