Skip to content

Improved schema svg export#11366

Closed
nobodypb wants to merge 3 commits intophpmyadmin:masterfrom
nobodypb:master
Closed

Improved schema svg export#11366
nobodypb wants to merge 3 commits intophpmyadmin:masterfrom
nobodypb:master

Conversation

@nobodypb
Copy link

@nobodypb nobodypb commented Aug 7, 2015

No description provided.

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I have the
    right to submit it under the license of "GNU General Public License or
    any later version" ("GPLv2-or-later"); or

(b) The contribution is based upon previous work that, to the best of my
    knowledge, is covered under an appropriate open source license and I have
    the right under that license to submit that work with modifications,
    whether created in whole or in part by me, under GPLv2-or-later; or

(c) The contribution was provided directly to me by some other person who
    certified (a) or (b) and I have not modified it.

(d) I understand and agree that this project and the contribution are public
    and that a record of the contribution (including all metadata and
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    phpMyAdmin's policies and the requirements of the GPLv2-or-later where
    they are relevant.

(e) I am granting this work to this project under the terms of the
    GPLv2-or-later.

    http://www.gnu.org/licenses/gpl-2.0.html

Signed-off-by: Sebastian Ott <sebastian@it-ott.de>
@lem9
Copy link
Contributor

lem9 commented Aug 7, 2015

Please explain what you are improving here.

@nobodypb
Copy link
Author

Sorry, got not much time ;)
In general it's readability. I changed the colors to be better visible.
I also removed the "fill" style from Line elements and replaced it with "stroke" as it has no impact on such thin lines. Same width of tables wasn't working correctly, I've fixed that too.
And finally I've added the viewBox attribute to the svg tag, and used the right dimensions for the svg.

I also replaced all line elements with polyline paths for better rendering in a local version of mine, but thats not part of this commit.

@lem9 lem9 self-assigned this Aug 10, 2015
@lem9
Copy link
Contributor

lem9 commented Aug 10, 2015

Thanks. I rebased your commits into just one: e29119c and merged that. See inside this commit for this line:

Signed-off-by: Sebastian Ott <sebastian@it-ott.de>

as we only need this line, not the whole DCO.

@lem9 lem9 closed this Aug 10, 2015
@lem9 lem9 added this to the 4.5.0 milestone Aug 10, 2015
@lem9 lem9 added the Enhancement A feature request for improving phpMyAdmin label Aug 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Enhancement A feature request for improving phpMyAdmin

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants