Allow sanitized markup in toastr message area #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
docs: showCloseButton is false by default
Allow latest react-redux as peer dependency
[Enhancement] Add 'id' as a configurable prop to toast confirm options.
[Docs] Add new 'id' prop on confirm options
Now it is possible to define suffics used in ARIA attributes at development rather than using `Math.random` at runtime
Author
|
Diego, The code has moved a bit since I first submitted this PR. Would you like me to resubmit the PR with a newer version of react-redux-toastr to get rid of the merge conflict in src/ToastrBox.js? -Dan |
Currently, this lib expects the state to be at the key `toastr` (and even handles when the state object is an immutable object (via `state.get`). There is no way to define a custom / different location easily. This adds an optional prop to the `ReduxToastr` component which is a function that takes the current state to provide the toastr state.
- bumping dev deps to dart-sass over deprecated node-sass - fix to build command
* Replaced if-then-else flow by a single return statement in functions isString and isBrowser * updated version to 7.6.9 Co-authored-by: Juan Carlos Rodriguez Salas <juan@MacBook-Pro.local>
* Rename file extension of jsx files from .js to .jsx. * Update webpack config to support .tsx files. --------- Co-authored-by: Nick Muller <nick@nickymuller.com>
* Fixed the "React (18.1.0) Toastr doesn't dissappear" issue Fix toastr removal in React 18 by using transitionend event listener * Moved the position to top-right from top-left * Fixed to run on crosspatform * Update client.js
Co-authored-by: printfn <printfn@users.noreply.github.com>
Add support for redux 5 and react-redux 9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Greets Diego,
I've added code that allows react-redux-toastr to display markup in it's messages. This was accomplished using:
I didn't bother making this an optional feature (to make this easier for you to review) but it probably should be?
If you like the idea of allowing markup then I'll wire in a configuration var, maybe something like allowHtml: false, and make sure that all the toastr methods play nice with the new feature. I'll update the manual along the way too if you accept this change.
Thanks Diego. Let me know if you're cool with allowing markup in the message area of the react-redux-toastr display.
-Dan