Skip to content

UofT-DSI | Shell - Assignment 1#1

Open
pbaisla wants to merge 4 commits intomainfrom
assignment
Open

UofT-DSI | Shell - Assignment 1#1
pbaisla wants to merge 4 commits intomainfrom
assignment

Conversation

@pbaisla
Copy link
Owner

@pbaisla pbaisla commented Nov 22, 2024

What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)

What did you learn from the changes you have made?

Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?

Were there any challenges? If so, what issue(s) did you face? How did you overcome it?

How were these changes tested?

A reference to a related issue in your repository (if applicable)

Checklist

  • I can confirm that my changes are working as intended

@github-actions
Copy link

Autograder results

question status
1
2
3
4
5
6
7
8
9

@pedram-aliniaye-asli
Copy link

you did a great job here!
A few things to notice:
The rm command works better with braces {} if properly expanded, but for clarity and flexibility, it’s better to break it into two commands:

rm ./data/raw/*ipaddr*
rm ./data/processed/user_logs/*ipaddr*

The ls command doesn’t expand ** without the right options. It's better to use find instead:

find ./data/processed/ -type f > ./data/inventory.txt
Please go ahead and close this pull request now. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants