Conversation
🦋 Changeset detectedLatest commit: 72d738e The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
✅ Commitlint tests passed!More Info{
"valid": true,
"errors": [],
"warnings": [],
"input": "fix(core): ssr events"
} |
✅ Deploy Preview for patternfly-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Contributor
Contributor
Contributor
bennypowers
added a commit
to RedHat-UX/red-hat-design-system
that referenced
this pull request
Jan 19, 2025
bennypowers
commented
Jan 20, 2025
Contributor
bennypowers
commented
Jan 27, 2025
Contributor
bennypowers
commented
Jan 27, 2025
bennypowers
commented
Jan 27, 2025
Member
Author
bennypowers
left a comment
bennypowers
left a comment
There was a problem hiding this comment.
This PR should be pared down to concentrate on lit, context-api, and table changes
slot controller changes should be deferred to another PR
Contributor
This will be addressed in a later PR
Contributor
pending later PR
Contributor
zeroedin
reviewed
Jan 31, 2025
Contributor
6 tasks
Contributor
adamjohnson
approved these changes
Apr 4, 2025
Collaborator
adamjohnson
left a comment
adamjohnson
left a comment
There was a problem hiding this comment.
Listeners grow through maintenance 👏
Contributor
zeroedin
approved these changes
Apr 4, 2025
Contributor
Contributor
|
@bennypowers I'll let you squash and merge here so you can look at the change I added due to updating the branch and changes made to scrollspycontroller in the meantime. |
This reverts commit 701f33f.
Member
Author
This comment has been minimized.
This comment has been minimized.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ## What I did
write a server-sidedeferred to feat(core): slot controller ssr hint attributes #2893SlotControllerwhich adds hint attributes to all elements that useSlotController.Testing Instructions
addEventListenerNotes to Reviewers
connectedCallbackandhostConnected- i suspect some of these should be refactored in order to make that more clear from the code