Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now the 2 points (the aggregated proof and the accumulator) that go into the pairing are subgroup checked. Then may be the points in the proofs don't have to be checked at the deserialization. I've never seen a proof of that. @AlistairStewart had a hackmd on that that i didn't find comprehensible.
I would also do the same for a standalone proof for consistency, but couldn't as it doesn't really make sense in the abstract setting.
So ~0.15 ms per a multiplication by the scalar field size. If we specialize to bls12-381 that would be may be 2x better due to the endomorphism.