Port remote-proxy pallet to polkadot-sdk #9088

dharjeezy · 2025-07-03T11:35:08Z

This adds remote proxy support to AssetHub on Polkadot and Kusama. Currently it is configured only to support using proxies registered on the relay chain to work on AssetHub. In the future this can be expanded. --------- Co-authored-by: Xiliang Chen <xlchen1291@gmail.com> Co-authored-by: Branislav Kontur <bkontur@gmail.com> Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

@franciscoaguirre

This Pull Request provides a minimal set of changes to support the upgrade to `stable2412` (to the latest available patch). ## Notable changes Here are the most notable changes: - `sp-std` removed for every runtime (except Encointer). Now we use `core` or `alloc` instead. - Mocked weights for `frame_system_extensions`, `pallet_transaction_payment`, and `xcm` on most runtimes. - Mocked weights for `pallet_identity` on People runtimes. - Update to XCMv5 started. ## Notable TODOs - [x] ~Review whether we need to make more changes regarding XCMv5~ (moved to a follow-up PR). @franciscoaguirre - [x] In Asset Hubs, the benchmarking options for `pallet-asset-conversion-tx-payment` is not exposed (or at least, is raising errors when trying to add it). - [x] For `polkadot-runtime`, do we still need `coretime_migration.rs`? @seadanda - [x] Assist with the initial implementation of `TransactionExtension` @georgepisaltu @gui1117 ## Open Question - Shouldn't we start using `frame`, `#[frame_construct_runtime]` and `#[derive_impl]` since they've already been proven to work? ## Help needed - [x] @clangenb to update and re-enable Encointer. ## Action List - [x] ~Remove any reference to either `NetworkId::Westend` and `NetworkId::Rococo` and replace with `NetworkId::ByGenesis`~ (moved to a follow-up PR). - [x] Upgrade to `stable2412-3` - [x] Setup filter for pallet-staking to exclude pool members. See comment [here](polkadot-fellows/runtimes#608 (comment)). ## Follow-up PRs - [ ] Refresh weights (to do before this release). ;) - [ ] Move to XCMv5. - [ ] Remove `sp-std`. --------- Signed-off-by: Andrei Sandu <andrei-mihail@parity.io> Co-authored-by: clangenb <37865735+clangenb@users.noreply.github.com> Co-authored-by: Dónal Murray <donalm@seadanda.dev> Co-authored-by: Francisco Aguirre <franciscoaguirreperez@gmail.com> Co-authored-by: Bastian Köcher <info@kchr.de> Co-authored-by: Andrei Sandu <andrei-mihail@parity.io> Co-authored-by: Clara van Staden <claravanstaden64@gmail.com> Co-authored-by: Andrei Sandu <54316454+sandreim@users.noreply.github.com> Co-authored-by: Branislav Kontur <bkontur@gmail.com> Co-authored-by: GitHub Action <action@github.com> Co-authored-by: Ankan <10196091+Ank4n@users.noreply.github.com> Co-authored-by: Alexandre Baldé <alexandre.balde@parity.io> Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

@claravanstaden

Is disabled encointer for now and copied over the weight files from Polkadot SDK to reduce errors. Will be overwritten by the bench bot anyways. ## Open Tasks - [x] Fix remaining errors in snowbridge test code @claravanstaden - [x] Enable Encointer and fix errors - [x] Bump to stable 2503-2 - [x] Find all missing storage migrations - [x] Update Changelog - [x] Waiting for new polkadot-sdk release with fixed pallet_session migration - [x] Waiting for new frame-omni-bencher binary with paritytech#8265 ## Follow Ups: - Rebench - Add pallet_revive to Kusama AssetHub - Bump `transaction_version` --------- Co-authored-by: Pablo Andrés Dorado Suárez <hola@pablodorado.com> Co-authored-by: Christian Langenbacher <clangenb+gh@protonmail.ch> Co-authored-by: claravanstaden <claravanstaden64@gmail.com> Co-authored-by: Branislav Kontur <bkontur@gmail.com> Co-authored-by: Dónal Murray <donal.murray@parity.io> Co-authored-by: Adrian Catangiu <adrian@parity.io> Co-authored-by: Ankan <ankan.anurag@gmail.com>

The change follows [polkadot-sdk's clippy usage](https://github.com/paritytech/polkadot-sdk/blob/4173aac8abc7e518d4048306c18d4f2176241206/.github/workflows/checks.yml#L39C1-L40C1) to also verify feature gated code like `test` or `runtime-benchmarks` It also fixes current findings (only tests and benchmarks related code) - [x] Does not require a CHANGELOG entry --------- Co-authored-by: Bastian Köcher <git@kchr.de>

bkchr · 2025-07-03T14:13:13Z

substrate/frame/remote-proxy/Cargo.toml

+cumulus-pallet-parachain-system = { workspace = true }
+cumulus-primitives-core = { workspace = true }
+frame-benchmarking = { workspace = true, optional = true }
+frame-support = { workspace = true }
+frame-system = { workspace = true }
+pallet-proxy = { workspace = true }
+sp-core = { workspace = true }
+sp-trie = { workspace = true }
+sp-runtime = { workspace = true }


Please upgrade to just use the frame crate.

when i tried specifying just the frame crate, i had this issue

error: failed to select a version for `polkadot-sdk-frame`. ... required by package `polkadot-service v7.0.1 (/Users/dharjeezy/Documents/polkadot-sdk/polkadot/node/service)` ... which satisfies path dependency `polkadot-service` (locked to 7.0.1) of package `cumulus-test-service v0.1.0 (/Users/dharjeezy/Documents/polkadot-sdk/cumulus/test/service)`

i have been able to get this done successfully @bkchr

bkchr · 2025-07-03T14:13:37Z

substrate/frame/remote-proxy/src/lib.rs

+			Ok(())
+		}
+
+		// TODO: Make upstream public and use that one.


Please fix this Todo :)

i have done this

bkchr · 2025-07-03T14:17:39Z

substrate/frame/remote-proxy/src/lib.rs

+
+				// We always remove all the old items before, thus there should always be space in
+				// the vector.
+				let _res = roots.try_push((block, hash));


Please check if the last item block number is already in there. This can happen because we sometimes build multiple parachain blocks on the same relay chain block.

Please also add a test for it.

i have done this

bkchr · 2025-07-03T14:18:35Z

CC @josepot

josepot · 2025-07-04T13:46:08Z

👋 @dharjeezy

Thanks a lot for porting this work into this repo!

Just an FYI that once this gets merged, I will start working on an improved version of this functionality, just in case that you have some thoughts/ideas about that improvement, or if you want to help me get that work done 🙂.

…let-from-runtimes # Conflicts: # Cargo.lock # polkadot/runtime/westend/Cargo.toml

dharjeezy · 2025-11-19T13:33:44Z

@bkchr can i get your review again here?

bkchr and others added 8 commits February 28, 2025 14:52

added pallet proxy src changes

5ac2d15

inclusion of pallet remote proxy from the runtime repo

60737dd

add remote proxy to Westend

56e528a

doc

5a21b35

dharjeezy marked this pull request as ready for review July 3, 2025 12:52

dharjeezy requested a review from a team as a code owner July 3, 2025 12:52

bkchr reviewed Jul 3, 2025

View reviewed changes

dharjeezy added 2 commits July 7, 2025 13:07

check for last item duplicates

bece9bf

check for last item duplicates

75033b0

dharjeezy requested a review from bkchr July 7, 2025 12:28

dharjeezy added 4 commits July 28, 2025 20:28

use just frame crate

07f65b5

nits

875b137

Merge remote-tracking branch 'origin/master' into dami/port-proxy-pal…

b1ffd03

…let-from-runtimes # Conflicts: # Cargo.lock # polkadot/runtime/westend/Cargo.toml

lock

3f63fce

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Port remote-proxy pallet to polkadot-sdk #9088

Port remote-proxy pallet to polkadot-sdk #9088

Uh oh!

dharjeezy commented Jul 3, 2025

Uh oh!

bkchr Jul 3, 2025

Uh oh!

dharjeezy Jul 7, 2025

Uh oh!

dharjeezy Jul 28, 2025

Uh oh!

bkchr Jul 3, 2025

Uh oh!

dharjeezy Jul 7, 2025

Uh oh!

bkchr Jul 3, 2025

Uh oh!

dharjeezy Jul 7, 2025

Uh oh!

bkchr commented Jul 3, 2025

Uh oh!

josepot commented Jul 4, 2025

Uh oh!

dharjeezy commented Nov 19, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Port remote-proxy pallet to polkadot-sdk #9088

Are you sure you want to change the base?

Port remote-proxy pallet to polkadot-sdk #9088

Uh oh!

Conversation

dharjeezy commented Jul 3, 2025

Uh oh!

bkchr Jul 3, 2025

Choose a reason for hiding this comment

Uh oh!

dharjeezy Jul 7, 2025

Choose a reason for hiding this comment

Uh oh!

dharjeezy Jul 28, 2025

Choose a reason for hiding this comment

Uh oh!

bkchr Jul 3, 2025

Choose a reason for hiding this comment

Uh oh!

dharjeezy Jul 7, 2025

Choose a reason for hiding this comment

Uh oh!

bkchr Jul 3, 2025

Choose a reason for hiding this comment

Uh oh!

dharjeezy Jul 7, 2025

Choose a reason for hiding this comment

Uh oh!

bkchr commented Jul 3, 2025

Uh oh!

josepot commented Jul 4, 2025

Uh oh!

dharjeezy commented Nov 19, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants