feat(go): add multi-module support to golangci-lint plugin and upgrade to v2 #22934
+168
−33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e to v2 - Add custom partitioner to group targets by owning go.mod - Run golangci-lint once per module with correct working directory - Upgrade default version from 1.64.6 to 2.7.1 - Keep v1 versions for backward compatibility - Add test for multi-module linting - Add test for v1 backward compatibility
kpurdon
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #22935
go.modChanges
Test plan
test_passing_v1verifies backward compatibility with v1.64.6test_multiple_go_modsverifies multi-module linting works correctly