Skip to content
This repository was archived by the owner on Oct 18, 2024. It is now read-only.

Conversation

@semireg
Copy link

@semireg semireg commented Feb 22, 2014

A few things to note:

  • The AngleGradientLayer is added as a subview of view.layer in order to decouple the relationship of the view to it's main layer. For example, the AngleGradientView can be rotated independently of the view itself, allowing for more effects.
  • A layer mask and bezier path(s) works great for creating oval or arc, or other arbitrarily shaped gradient layers.
  • An outline layer allows for complex borders.
  • Nothing has really changed inside AngleGradientLayer.

@paiv
Copy link
Owner

paiv commented Feb 24, 2014

Hi @caylanlarson. I have reviewed your request but I'm not ready to merge it -- here is my point:

  1. AngleGradientView is a good abstraction in the context of this demo project, but I consider this an overhead for the library. I'd rather developers know the steps needed to operate directly with CALayer.
  2. Masking and outlines -- are composition of layers, and as such are not required to be integrated into the library itself. So I'd rather keep this outside the library and let developers make their compositions however they like it.

@semireg
Copy link
Author

semireg commented Feb 24, 2014

Hi @paiv. Thanks for the feedback. I agree with you.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants