Open
Conversation
quentinus95
requested changes
Aug 9, 2017
Member
quentinus95
left a comment
quentinus95
left a comment
There was a problem hiding this comment.
I would prefer you to use a location resource (with a one to one between metadata and location) with two latitude/ longitude fields to have a standardised way to store the locations
quentinus95
requested changes
Aug 10, 2017
Member
quentinus95
left a comment
quentinus95
left a comment
There was a problem hiding this comment.
Some issues with the code style
| */ | ||
| class Location | ||
| { | ||
|
|
|
|
||
| /** | ||
| * | ||
| * |
| */ | ||
| protected $latitude; | ||
|
|
||
|
|
|
|
||
| /** | ||
| * | ||
| * |
| */ | ||
| protected $longitude; | ||
|
|
||
|
|
| private $metadata; | ||
|
|
||
| /** | ||
| * @return Metadata |
Member
There was a problem hiding this comment.
Please remove all the annotation blocks from the methods
| { | ||
| $this->longitude = $longitude; | ||
| } | ||
|
|
| return $this; | ||
| } | ||
|
|
||
| public function getLocation() |
Member
There was a problem hiding this comment.
Return type is missing (here it should be ?Location)
mike1796
reviewed
Aug 15, 2017
Member
mike1796
left a comment
mike1796
left a comment
There was a problem hiding this comment.
You should also use php-cs-fixer to correct differents problems for the validity of your PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.