Add read_panic_message kipc
#2313
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hawkw
commented
Dec 3, 2025
hawkw
force-pushed
the
eliza/read-panic-message
branch
2 times, most recently
from
c4ca702 to
2c80a58
Compare
Currently, there is no way to programmatically access the panic message of a task which has faulted due to a Rust panic fron within the Hubris userspace. This branch adds a new `read_panic_message` kipc that copies the contents of a panicked task's panic message buffer into the caller. If the requested task has not panicked, this kipc returns an error indicating this. This is intended by use by supervisor implementations or other tasks which wish to report panic messages from userspace. I've also added a test case that exercises this functionality. Fixes #2311
hawkw
force-pushed
the
eliza/read-panic-message
branch
from
2c80a58 to
5ba535a
Compare
mkeeter
reviewed
Dec 3, 2025
mkeeter
reviewed
Dec 3, 2025
sys/kern/src/kipc.rs
Outdated
Comment on lines
522
to
526
| if index >= tasks.len() { | ||
| return Err(UserError::Unrecoverable(FaultInfo::SyscallUsage( | ||
| UsageError::TaskOutOfRange, | ||
| ))); | ||
| } |
Collaborator
There was a problem hiding this comment.
Similarly, something like
Suggested change
| if index >= tasks.len() { | |
| return Err(UserError::Unrecoverable(FaultInfo::SyscallUsage( | |
| UsageError::TaskOutOfRange, | |
| ))); | |
| } | |
| let Some(task) = tasks.get(index) else { | |
| return Err(UserError::Unrecoverable(FaultInfo::SyscallUsage( | |
| UsageError::TaskOutOfRange, | |
| ))); | |
| }; |
(then use task below instead of indexing repeatedly)
Co-authored-by: Matt Keeter <matt@oxide.computer>
mkeeter
reviewed
Dec 3, 2025
labbott
reviewed
Dec 3, 2025
hawkw
added
kernel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, there is no way to programmatically access the panic message of a task which has faulted due to a Rust panic fron within the Hubris userspace. This branch adds a new
read_panic_messagekipc that copies the contents of a panicked task's panic message buffer into the caller. If the requested task has not panicked, this kipc returns an error indicating this. This is intended by use by supervisor implementations or other tasks which wish to report panic messages from userspace.I've also added a test case that exercises this functionality.
Fixes #2311