Skip to content

Conversation

@ouankou
Copy link
Owner

@ouankou ouankou commented Nov 24, 2025

Issue

  • ctest openacc_vv_loop_collapse_force.c occasionally dropped the collapse count, producing collapse(force) instead of collapse(force:2).
  • Root cause: the lexer counters (parenthesis/bracket/colon) were left uninitialized and the collapse token did not prime colon_count, so the colon could prematurely end the expression depending on stack garbage.

Solution

  • Initialize lexer delimiter/colon counters so expression lexing always starts from a known state.
  • Seed colon_count when lexing collapse to allow colon-delimited modifiers (force:2) to remain inside the expression mode.

Testing

  • ctest -R "openacc_vv_loop_collapse_force.c" --output-on-failure --repeat-until-fail 200
  • ctest --output-on-failure

@ouankou
Copy link
Owner Author

ouankou commented Nov 24, 2025

@codex review

@chatgpt-codex-connector
Copy link

Codex Review: Didn't find any major issues. 🚀

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@ouankou ouankou merged commit bf09136 into main Nov 24, 2025
11 checks passed
@ouankou ouankou deleted the fix-collapse-colon branch November 24, 2025 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants