-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Fix: Update OpenCode skills directory path to match official spec #216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Update all references from 'opencode/skills' to 'opencode/skill' to align with OpenCode Agent Skills documentation (https://opencode.ai/docs/skills) Changes: - .opencode/plugin/superpowers.js: Update project and personal skills dir paths - docs/README.opencode.md: Update all path references in documentation This fixes the issue where OpenCode rejects the 'skills' directory name and requires 'skill' (singular) instead.
📝 WalkthroughWalkthroughProject and personal "skills" directories were renamed from plural to singular: project Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
📜 Recent review detailsConfiguration used: defaults Review profile: CHILL Plan: Pro 📒 Files selected for processing (3)
🔇 Additional comments (6)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (1)
.opencode/plugin/superpowers.js (1)
160-160: Improve error message to mention all skill locations.The error message references superpowers and project skill directories but omits the personal skills directory (
~/.config/opencode/skill/). Consider including all three locations to help users understand their options.🔎 Suggested improvement
- return 'No skills found. Install superpowers skills to ~/.config/opencode/superpowers/skills/ or add project skills to .opencode/skill/'; + return 'No skills found. Install superpowers skills to ~/.config/opencode/superpowers/skills/, add personal skills to ~/.config/opencode/skill/, or add project skills to .opencode/skill/';
📜 Review details
Configuration used: defaults
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
.opencode/plugin/superpowers.jsdocs/README.opencode.md
🔇 Additional comments (4)
.opencode/plugin/superpowers.js (1)
44-47: LGTM!The comment updates correctly reflect the new singular directory paths and provide clear guidance on the skill priority ordering.
docs/README.opencode.md (3)
73-79: LGTM!Personal skills documentation accurately reflects the new singular directory structure with consistent path references and clear examples.
98-101: LGTM!Project skills documentation correctly updated with the new singular directory paths and consistent examples.
118-120: LGTM!The skill priority documentation correctly reflects the new directory structure. Note that the superpowers installation directory correctly remains plural (
skills/) as it's distinct from user-created personal and project skill directories.
Update all references from 'opencode/skills' to 'opencode/skill' (singular) to align with the OpenCode Agent Skills documentation. Changes: - .opencode/plugin/superpowers.js: Update project and personal skills dir paths - docs/README.opencode.md: Update all path references in documentation - tests/opencode/setup.sh: Update test fixture paths - tests/opencode/test-plugin-loading.sh: Update fixture verification path - tests/opencode/test-priority.sh: Update all priority test fixture paths This fixes the issue where OpenCode rejects the 'skills' directory name and requires 'skill' (singular) instead. Reference: https://opencode.ai/docs/skills
|
This PR has 2 commits with the same title because I forgot to check the |
Update all references from 'opencode/skills' to 'opencode/skill' to align with OpenCode Agent Skills documentation (https://opencode.ai/docs/skills)
Changes:
skillsto singularskill.This fixes a critical issue where
find_skillscannot locate user-defined skills, and users are prevented from applying a workaround by OpenCode core itself.Motivation and Context
The official OpenCode documentation mandates that user-defined skills reside in
.opencode/skill(singular).The current implementation of
superpowersincorrectly searches for a pluralskillsdirectory.Crucially, users cannot manually rename their directory to
skillsto work around this bug, because OpenCode core strictly enforces the naming convention and throws the following error on startup:This creates a deadlock where the plugin expects a directory name that the core application explicitly forbids. This PR resolves this conflict by aligning the plugin with the core specification.
How Has This Been Tested?
I tested this locally on macOS:
skill(as required by OpenCode core).superpowers.js.use find_skills toolwithin OpenCode.~/.config/opencode/skill(global skills) and.opencode/skill(project skills).Breaking Changes
None.
Previously, it was impossible to use custom skills with this plugin because OpenCode core would reject the
skillsdirectory required by the plugin. This change enables the intended functionality.Types of changes
Checklist
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.