Skip to content

Conversation

@benjamincanac
Copy link
Member

@benjamincanac benjamincanac commented Nov 26, 2025

πŸ”— Linked issue

Resolves #5536, resolves #5359, resolves #5637

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@github-actions github-actions bot added the v4 #4488 label Nov 26, 2025
@benjamincanac
Copy link
Member Author

@BobbieGoede I'd love your feedback on this, would this work?

@pkg-pr-new
Copy link

pkg-pr-new bot commented Nov 26, 2025

npm i https://pkg.pr.new/@nuxt/ui@5537

commit: c8a7002

benjamincanac and others added 2 commits December 8, 2025 14:37
Co-authored-by: Bobbie Goede <bobbiegoede@gmail.com>
@benjamincanac
Copy link
Member Author

@BobbieGoede I have another question, what will happen if users have already passed localePath or localeRoute to the to prop? I don't want to break existing apps 😬

@BobbieGoede
Copy link
Member

@BobbieGoede I have another question, what will happen if users have already passed localePath or localeRoute to the to prop? I don't want to break existing apps 😬

Passing localized paths/routes to localePath and localeRoute should work, but will still localize it to the current language since no locale parameter is passed, so this is breaking for users passing localized paths pointing to other languages.

You might want to add a prop to the component so users can both opt-in to localization and/or specify the language (something like locale: true | string). You could also add a config option to invert it so that it's opt-out instead (like this draft for example nuxt-modules/i18n#3530).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

v4 #4488

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NavigationMenu is not working with the i18n. ULink or UButton link with locale How to have localized links in ContentSearch?

3 participants