-
Notifications
You must be signed in to change notification settings - Fork 0
my attempt at assignment 1 #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Autograder results
| question | status | comment |
|---|---|---|
| Part 1 - Q1 | ✅ | |
| Part 1 - Q2 | ✅ | |
| Part 1 - Q3 | ✅ | |
| Part 1 - Q4 | ✅ | |
| Part 1 - Q5 | ✅ | |
| Part 1 - Q6 | ✅ | |
| Part 1 - Q7 | ✅ | |
| Part 1 - Q8 | ❌ | data/inventory.txt does not contain all files in data/processed |
| Part 2 | ❌ | coworker-changes branch not found in commit history |
Please address the issues listed above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Autograder results
| question | status | comment |
|---|---|---|
| Part 1 - Q1 | ✅ | |
| Part 1 - Q2 | ✅ | |
| Part 1 - Q3 | ✅ | |
| Part 1 - Q4 | ✅ | |
| Part 1 - Q5 | ✅ | |
| Part 1 - Q6 | ✅ | |
| Part 1 - Q7 | ✅ | |
| Part 1 - Q8 | ✅ | |
| Part 2 | ❌ | coworker-changes branch not found in commit history |
Please address the issues listed above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Autograder results
| question | status |
|---|---|
| Part 1 - Q1 | ✅ |
| Part 1 - Q2 | ✅ |
| Part 1 - Q3 | ✅ |
| Part 1 - Q4 | ✅ |
| Part 1 - Q5 | ✅ |
| Part 1 - Q6 | ✅ |
| Part 1 - Q7 | ✅ |
| Part 1 - Q8 | ✅ |
| Part 2 | ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Autograder results
| question | status | comment |
|---|---|---|
| Part 1 - Q1 | ✅ | |
| Part 1 - Q2 | ✅ | |
| Part 1 - Q3 | ✅ | |
| Part 1 - Q4 | ✅ | |
| Part 1 - Q5 | ✅ | |
| Part 1 - Q6 | ✅ | |
| Part 1 - Q7 | ❌ | One or more files with ipaddr in data/raw not removed.; One or more files with ipaddr in data/processed/user_logs not removed |
| Part 1 - Q8 | ❌ | data/inventory.txt does not exist |
| Part 2 | ✅ |
Please address the issues listed above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Autograder results
| question | status |
|---|---|
| Part 1 - Q1 | ✅ |
| Part 1 - Q2 | ✅ |
| Part 1 - Q3 | ✅ |
| Part 1 - Q4 | ✅ |
| Part 1 - Q5 | ✅ |
| Part 1 - Q6 | ✅ |
| Part 1 - Q7 | ✅ |
| Part 1 - Q8 | ✅ |
| Part 2 | ✅ |
Dmytro-Bonislavskyi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @ntahmo Well done!
What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
Adding code
What did you learn from the changes you have made?
The working directory can lead to many errors when preparing a script
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
How to create subfolders in a new folder all in one line of code
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
No
How were these changes tested?
I ran the script locally
A reference to a related issue in your repository (if applicable)
Checklist