Open
Conversation
…reflects MF6 interface
Member
|
@nathangibson14 You're aware that the tests seem to fail? |
Contributor
Author
|
I saw that Actions failed, but I have no idea why. The tests pass for me locally. I've made enough changes, though, that it's not worth figuring out what happened here for now. I'll keep an eye on it down the road. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here is the start of GENDF capabilities reimagined. This represents a good start, but there's quite a bit more to do.
CrossSectionstill needs constructors from parameters. Then, there will be sister classes toCrossSectioncalledRatioandMatrix, plus possiblyDelayedFission. And MFD1 will need special treatment. Printing is yet to come.Syntax tree/parse is further down the road, but it'll come!
But I'd rather get some feedback from @whaeck before I get too far on this one.