Ugly MAB POC #70
Open
Ugly MAB POC #70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #70 +/- ##
==========================================
- Coverage 88.30% 86.68% -1.62%
==========================================
Files 64 64
Lines 4087 4176 +89
==========================================
+ Hits 3609 3620 +11
- Misses 333 411 +78
Partials 145 145
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
nfx
reviewed
Jan 3, 2023
pool/shard.go
Outdated
| work chan work //todo channel in pool | ||
| minute *time.Ticker | ||
| ticks int | ||
| src *rand.Rand |
Owner
There was a problem hiding this comment.
Rename this to "rnd", because src is a bit misleading name here. At least it got me confused
pool/shard.go
Outdated
| if pool.handleReanimate() { | ||
| ctx.Heartbeat() | ||
| } | ||
| nt := float64(0.0) |
Owner
There was a problem hiding this comment.
Go tip: "var nt float64" should do the same
pool/shard.go
Outdated
| //inspired by https://cybernetist.com/2019/01/24/random-weighted-draws-in-go/ | ||
| cdf := make([]float64, size) | ||
| weights := make([]float64, size) | ||
| const explorationRate = 0.04 |
pool/shard.go
Outdated
| // continue | ||
| //} | ||
| e.Offered += 1 | ||
| a := e.Offered |
Owner
There was a problem hiding this comment.
Hm... I think it's better to be doing it on "running counters", rather than global counters
# Conflicts: # go.mod # go.sum # pool/shard.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
thompson sampling prototype