Add alternative name search for local editable package#648
Closed
dominusmi wants to merge 2 commits intonficano:masterfrom
Closed
Add alternative name search for local editable package#648dominusmi wants to merge 2 commits intonficano:masterfrom
dominusmi wants to merge 2 commits intonficano:masterfrom
Conversation
Author
|
I've realised there's an error when the local package has the same name as a package on the public |
Author
|
Fixed local package name conflict error |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When packages are installed in editable mode, in certain cases (e.g. package is connected to private repository) the path that
pip freezeoutputs is of the shape-e git+git@github.com:repo_name@commithash#egg=package_name&other_headers=..The current way to deal with editable package is simply to remove the
-e, however this clearly doesn't work in this case.This PR adds an alternative name search by using
eggas an anchor, with a regex.It imports
re(standard lib so no added requirements).The added code doesn't break anything, it only tries to install the alternative package name if the first fails.
The main regex is
egg=([\w+_-]+); the only doubt I have is whether the pattern covers all possible valid python module names.