fix(dav): avoid TypeError on public DAV HEAD range #2241
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: hgrobbel <hubertus@grobbel.net>
hubimuc
force-pushed
the
fix/dav-head-range
branch
from
b965413 to
7664475
Compare
Member
|
Should be handled upstream? |
Author
|
issue is filed in sabre-io/dav#1618
Please refer to issue: sabre-io/dav#1618 |
OK for me Co-authored-by: Josh <josh.t.richards@gmail.com> Signed-off-by: hubimuc <hubertus@grobbel.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix TypeError in Sabre CorePlugin when handling public DAV HEAD range requests by converting string bodies to streams before range handling.
Problem
Public share DAV
HEAD+Rangecan hitstream_get_meta_data()with a string body, causing a TypeError and breaking byte‑range streaming (e.g. slow PDF load).Related: nextcloud/server#57219
Fix
Convert string
$bodytophp://tempstream regardless of request method.Testing
Before:
500 Internal Server ErrorAfter:
206 Partial Content+Content-Range